More py.path removal work #8446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def pytest_collect_file(parent, path): | ||
| if path.ext == ".yaml" and path.basename.startswith("test"): | ||
| return YamlFile.from_parent(parent, fspath=path) | ||
| def pytest_collect_file(parent, fspath): |
There was a problem hiding this comment.
seeing this reminds me - adding those parameters is a breaking changes for externals that use those,
i believe it adds errors on some plugins, please see #8361
RonnyPfannschmidt
approved these changes
Mar 15, 2021
|
doc failure unrelated |
…akedir() It is not possible to change a return type in a compatible way, so a new method is added.
The main reason is to remove a reference to `py.path`.
bluetech
force-pushed
the
unnecessary-py-path-2
branch
from
779df59 to
f0c7043
Compare
|
The coverage will bounce back after the planned revert mentioned in #8361 (comment). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit adds
cache.mkdir, a replacement for the py.path-returningcache.makedir.Second commit makes
collect_ignoreagnostic topy.path.Third commits are some random replacements of py.path uses with the pathlib equivalents.