Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hermes support #54
hermes support #54
Changes from 2 commits
ffdd934
5691b9f
8389737
c22f8ba
0faca3d
6d1d4d8
7036e70
6fdcec0
41426be
ab9149a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did you follow the v1 api schema? maybe good to implement for v2 instead since that is live already e.g. https://hermes.pyth.network/docs/#/rest/latest_price_updates
but happy to defer to @ali-bahjati on what the right action here is
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the
httpx.AsyncClient
is instantiated but not explicitly closed, which could potentially lead to resource leaks, maybe use the client as a context manager to ensure it's properly closed e.g.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issue is that with context manager usage, any one call will close the client which makes it impossible to open again. I think using
asyncio.run
manages the resource leakage by closing all tasks running within the event loop whenever it's shut down: https://github.com/python/cpython/blob/c0b0c2f2015fb27db4306109b2b3781eb2057c2b/Lib/asyncio/runners.py#L64-L79There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why does
self.pending_feed_ids
not require uniqueness?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we always call
list(set(self.feed_ids))
, so the feed_ids will always be uniqueThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's possible for
self.pending_feed_ids
to contain duplicates if the same feed IDs are added more than once before they are cleared, for e.g.add_feed_ids
method is called with['feed1', 'feed2']
self.pending_feed_ids
is performed,add_feed_ids
is called again with['feed2', 'feed3']
self.feed_ids
will now contain['feed1', 'feed2', 'feed3']
without duplicates because it's converted to a set and then back to a listself.pending_feed_ids
will contain['feed1', 'feed2', 'feed2', 'feed3']
, where'feed2'
is duplicated.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
imo you can do something like this to make it cleaner
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
another thing that we can possibly do here is to validate that the
feed_ids
passed in is in the format we expecte.g.
and then call
validate_feed_ids
in the first line ofadd_feed_ids
and write tests to ensure that invalid ids (e.g. 30 chars, invalid chars, etc) throw an errorThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a specific reason to do this? otherwise I recommend to import it at top-level to improve readability and maintainability
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think we did this so that we didn't import these when we were using non-websocket client--i think it was more relevant where we had the code before, I think here it's def better to move to top