-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(hermes-client)!: Correct filter parameter to assetType in getPriceFeeds function #2248
base: main
Are you sure you want to change the base?
Conversation
@ryunix is attempting to deploy a commit to the Pyth Network Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Hello, maintainers. I would like to add some more details about the changes in this pull request. Below are examples of the code execution before and after the changes: View examples of code execution before and after the changesThe command to be executed was copied from the README.md file. Before ChangesIn this execution, no filtering was applied based on the
After ChangesIn this execution, filtering based on the
Thank you for considering my pull request. I look forward to your feedback! |
This pull request corrects the filter parameter to assetType in the getPriceFeeds function. The original filter parameter did not perform filtering correctly due to a mismatch with the server's parameter name.
This change introduces a breaking change, as the public API parameter name has been updated. Existing users will need to update their code from filter to assetType. As a result, the version has been bumped to 2.0.0 to reflect this change.