Make validation notes picklable. #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PIG208
changed the title
Certain test runners pickle the exceptions raised to accumulate them from multiple processes. For exceptions with `AttributeValidationNote` and/or `IterableValidationNote` attached, because we have overridden `__new__` on these classes, pickle cannot correctly unpickle them with the required arguments. For this use case, exceptions being picklable is necessary to accumulate errors with the `multiprocessing` setup. This implements `__getnewargs__` to fix this problem. Certain test runners that pickle the exceptions raised to accumulate them from multiple processes. For exceptions with `AttributeValidationNote` and/or `IterableValidationNote`, because we have overriden __new__ on these classes, pickle is not able to correctly unpickle them with the required arguments. This implements __getnewargs__ to fix this problem. Signed-off-by: Zixuan James Li <p359101898@gmail.com>
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certain test runners (in my case, Django's
RemoteTestRunner) pickle the exceptions raised to accumulate them from multiple processes.For exceptions with
AttributeValidationNoteand/orIterableValidationNoteattached, because we have overridden__new__on these classes, pickle cannot correctly unpickle them with the required arguments. For this use case, exceptions being pickable is necessary to accumulate errors with themultiprocessingsetup.This implements
__getnewargs__to fix this problem.