-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Embetter pofile sorting #300
Conversation
Current coverage is
|
94bff46
to
0b70da8
Compare
@jtwang DRYed! Good point. |
for comment in message.user_comments: | ||
_write_comment(comment) | ||
_write_message(message, prefix='#~ ') | ||
_write('\n') | ||
|
||
|
||
def _sort_messages(messages, sort_by_message, sort_by_file): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test please and docs. No default values for sort flags?
@jtwang: I improved the signature of the helper function a little more -- no good reason to have two mutually exclusive arguments! Also, I don't think it warrants a separate test; that function's coverage should already be 100% by way of the other tests. |
Cheers @jtwang! :) |
I think sorting message locations irrespective of the sort flags is alright.
The only UC I can think of where that wouldn't be desired might be trying to read a .po and emitting an identical copy of it, but I don't think Babel does that as it is anyway?