Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Day period API #349

Merged
merged 4 commits into from
Mar 9, 2016
Merged

Day period API #349

merged 4 commits into from
Mar 9, 2016

Conversation

akx
Copy link
Member

@akx akx commented Feb 15, 2016

This PR adds full support for day periods other than am/pm.

Requested by @sachinpali146 for additional time format character support. :)

See: http://unicode.org/reports/tr35/tr35-dates.html#Day_Period_Rules

@codecov-io
Copy link

Current coverage is 89.71%

Merging #349 into master will increase coverage by +0.01% as of 910f20c

@@            master    #349   diff @@
======================================
  Files           23      23       
  Stmts         3808    3840    +32
  Branches         0       0       
  Methods          0       0       
======================================
+ Hit           3416    3445    +29
  Partial          0       0       
- Missed         392     395     +3

Review entire Coverage Diff as of 910f20c

Powered by Codecov. Updated on successful CI builds.

@RauliL
Copy link

RauliL commented Mar 9, 2016

LGTM.

@akx
Copy link
Member Author

akx commented Mar 9, 2016

(@RauliL is a colleague who I recruited to do code review here.)

akx added a commit that referenced this pull request Mar 9, 2016
@akx akx merged commit f5bd94d into python-babel:master Mar 9, 2016
@akx akx deleted the import-day-periods branch March 9, 2016 07:36
@pyup-bot pyup-bot mentioned this pull request Apr 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants