Add information about precision on format_percent #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gitmate-bot
added
process/pending review
pending review
size/S
and removed
process/pending review
labels
Current coverage is 90.15% (diff: 100%)@@ master #460 diff @@
==========================================
Files 24 24
Lines 3979 3983 +4
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 3587 3591 +4
Misses 392 392
Partials 0 0
|
gitmate-bot
added
process/pending review
size/M
and removed
process/pending review
size/S
labels
gitmate-bot
reviewed
Dec 27, 2016
| @@ -346,21 +346,45 @@ def format_percent(number, format=None, locale=LC_NUMERIC): | |||
| u'2,512%' | |||
| >>> format_percent(25.1234, locale='sv_SE') | |||
| u'2\\xa0512\\xa0%' | |||
|
|
|||
There was a problem hiding this comment.
Line contains following spacing inconsistencies:
- Trailing whitespaces.
SpaceConsistencyBear, severity NORMAL, section default.
The issue can be fixed by applying the following patch:
--- a/babel/numbers.py
+++ b/babel/numbers.py
@@ -346,7 +346,7 @@
u'2,512%'
>>> format_percent(25.1234, locale='sv_SE')
u'2\\xa0512\\xa0%'
-
+
You can set the percent precision changing the scale
>>> format_percent(0.345, locale='en_US', scale=2)
u'34.50%'
gitmate-bot
reviewed
Dec 27, 2016
| @@ -346,21 +346,45 @@ def format_percent(number, format=None, locale=LC_NUMERIC): | |||
| u'2,512%' | |||
| >>> format_percent(25.1234, locale='sv_SE') | |||
| u'2\\xa0512\\xa0%' | |||
|
|
|||
There was a problem hiding this comment.
Line contains following spacing inconsistencies:
- Trailing whitespaces.
SpaceConsistencyBear, severity NORMAL, section default.
The issue can be fixed by applying the following patch:
--- a/babel/numbers.py
+++ b/babel/numbers.py
@@ -346,7 +346,7 @@
u'2,512%'
>>> format_percent(25.1234, locale='sv_SE')
u'2\\xa0512\\xa0%'
-
+
You can set the percent precision changing the scale
>>> format_percent(0.345, locale='en_US', scale=2)
u'34.50%'
gitmate-bot
reviewed
Dec 27, 2016
| @@ -346,21 +346,45 @@ def format_percent(number, format=None, locale=LC_NUMERIC): | |||
| u'2,512%' | |||
| >>> format_percent(25.1234, locale='sv_SE') | |||
| u'2\\xa0512\\xa0%' | |||
|
|
|||
There was a problem hiding this comment.
Line contains following spacing inconsistencies:
- Trailing whitespaces.
SpaceConsistencyBear, severity NORMAL, section default.
The issue can be fixed by applying the following patch:
--- a/babel/numbers.py
+++ b/babel/numbers.py
@@ -346,7 +346,7 @@
u'2,512%'
>>> format_percent(25.1234, locale='sv_SE')
u'2\\xa0512\\xa0%'
-
+
You can set the percent precision changing the scale
>>> format_percent(0.345, locale='en_US', scale=2)
u'34.50%'
gitmate-bot
reviewed
Dec 27, 2016
| @@ -346,21 +346,45 @@ def format_percent(number, format=None, locale=LC_NUMERIC): | |||
| u'2,512%' | |||
| >>> format_percent(25.1234, locale='sv_SE') | |||
| u'2\\xa0512\\xa0%' | |||
|
|
|||
There was a problem hiding this comment.
Line contains following spacing inconsistencies:
- Trailing whitespaces.
SpaceConsistencyBear, severity NORMAL, section default.
The issue can be fixed by applying the following patch:
--- a/babel/numbers.py
+++ b/babel/numbers.py
@@ -346,7 +346,7 @@
u'2,512%'
>>> format_percent(25.1234, locale='sv_SE')
u'2\\xa0512\\xa0%'
-
+
You can set the percent precision changing the scale
>>> format_percent(0.345, locale='en_US', scale=2)
u'34.50%'
|
This is conflicted by #494, so closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've written more information about precision on format_percent.