Restore force_frac to NumberPattern.apply() (as deprecated) #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This retains backwards compatibility (at least as far as the function's signature is concerned) with users that are using NumberPattern.apply() directly. See: python-babel#550 See: python-babel#569
|
@kdeldycke Can I ask you to look over this real quick, as you're the decimal architect? :) |
Codecov Report
@@ Coverage Diff @@
## master #577 +/- ##
==========================================
- Coverage 90.23% 90.19% -0.05%
==========================================
Files 24 24
Lines 4045 4048 +3
==========================================
+ Hits 3650 3651 +1
- Misses 395 397 +2
Continue to review full report at Codecov.
|
|
This PR is indeed good enough to temporarily restore backward-compatibility while we wait for removing that in a future release. Let's merge! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This retains backwards compatibility (at least as far as the function's
signature is concerned) with users that are using NumberPattern.apply()
directly.
See: #550
See: #569
Also refs #494 and #538.