Update test dependencies (tox v4) #953
Merged
+10
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akx
requested changes
Jan 20, 2023
.github/workflows/test.yml
Outdated
| @@ -40,11 +40,11 @@ jobs: | |||
| - name: Install dependencies | |||
| run: | | |||
| python -m pip install --upgrade pip setuptools wheel | |||
| python -m pip install 'tox<4.0.0' 'tox-gh-actions==2.12.0' | |||
| python -m pip install 'tox~=4.0' 'tox-gh-actions~=3.0' | |||
There was a problem hiding this comment.
Can you actually switch us to the first-party tox-dev/tox-gh instead?
Just requires changing [gh-actions] to [gh] in the ini file.
Codecov Report
@@ Coverage Diff @@
## master #953 +/- ##
==========================================
+ Coverage 90.18% 90.48% +0.30%
==========================================
Files 24 24
Lines 4391 4393 +2
==========================================
+ Hits 3960 3975 +15
+ Misses 431 418 -13
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since tox-gh-actions has a stable release supporting tox v4, both dependencies can be updated.
To test with tox v4,
whitelist_externalsneeds to be replaced withallowlist_externals.Also updates codecov/codecov-action from v2 to v3.