Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

list_translations should always return the default locale #75

Closed
ghost opened this issue Aug 21, 2015 · 2 comments
Closed

list_translations should always return the default locale #75

ghost opened this issue Aug 21, 2015 · 2 comments

Comments

@ghost
Copy link

ghost commented Aug 21, 2015

list_translations() currently only returns the default locale if no translation files exist. I believe it should always return the default locale.

For example, if my keys are in English, I will not have a .mo for English, but it is still a valid locale and would be returned as such if I hadn't yet translated into German.

Furthermore, I think that the default locale should be returned even if the translations folder does not exist (currently an empty list is returned in this case) - why is that any different to an empty translations folder?

@rlam3
Copy link

rlam3 commented Nov 19, 2015

+1

@lafrech
Copy link

lafrech commented Sep 15, 2016

I also think that the default locale should always be included.

Should we send a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants