Fix for untranslated plurals when using multiple domains #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When translations from different catalogs are being merged, there is a workaround to copy the `plurals()` function from the catalog to the combined `translations` object. If the locale catalog doesn't exist for a particular domain, a default value is copied, overriding the proper `plurals()`function. This results in the plural version of a string not being translated for languages with different plural values. See for instance `test_gettext.py::test_plurals_different_domains`: the Japanese locale exists only in the `messages` domain (`translations` folder) but not on the `myapp` one (`translations_different_domain` folder). First reported in ckan/ckan#8258
|
Didn't get a chance to test this today as the CI tooling was out of date and had to be updated first. Will get to this tomorrow. |
|
@amercader Looks good, but there's a failure in the tests under pypy. Looks like the tests might be depending on the ordering of the translation list, https://github.com/python-babel/flask-babel/actions/runs/9577423964/job/26405619814 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When translations from different catalogs are being merged, there is a workaround to copy the
plurals()function from the catalog to the combinedtranslationsobject. If the locale catalog doesn't exist for a particular domain, a default value is copied, overriding the properplurals()function. This results in the plural version of a string not being translated for languages with different plural values.See for instance
test_gettext.py::test_plurals_different_domains: the Japanese locale exists only in themessagesdomain (translationsfolder) but not on themyappone (translations_different_domainfolder).First reported in ckan/ckan#8258