Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unquote URL path which is matched against property key, which is also… #13

Merged
merged 1 commit into from
Jun 3, 2017

Conversation

andrei-mart
Copy link
Contributor

… quoted

Minor optimization of search in a dictionary
ref #11

… quoted

Minor optimization of search in a dictionary
ref python-caldav#11
@andrei-mart
Copy link
Contributor Author

There is a problem to add a test.
The test would depend on server setup, and test servers are not a part of the test suite.
The environment I tested against uses email addresses as user names, and user name is also a part of base path, and '@' in the key returned from _handle_prop_response() was quoted. I got the error in very basic case: principal.calendars() failed. Current test suite has that call, and I expect it will fail if one of the test environments is set up as mentioned above. It may be enough to create user with name containing @ or # or & or < or > or any other character that should be quoted in URL.

@tobixen
Copy link
Member

tobixen commented Jun 2, 2017

Maybe it's possible to create a calendar with @ in the name?

@andrei-mart
Copy link
Contributor Author

I tried to add @ to IDs, tests pass anyway.
Should it be in the name?
We want it to appear in the path when a property is returned. I am not familiar with caldav protocol and have no idea how to achieve that.

@tobixen tobixen merged commit 69aa91b into python-caldav:master Jun 3, 2017
@tobixen
Copy link
Member

tobixen commented Jun 3, 2017

I'll merge this and look more into it when I get the time.

@Achimh3011
Copy link
Contributor

I just ran into this problem after a zimbra upgrade (user is identified by mail address). The PR solves this.

Everything fine, except: when will a new version be released on PyPI? I hate it when I need to reference package dependencies as git repositories...

@tobixen
Copy link
Member

tobixen commented Feb 24, 2018

I hoped to get time to look more into caldav previous week, but ... time is passing so quickly. I got into some test failures, it seems like one of my caldav test servers is just dropping VTODO items rather than saving them. Once this issue is fixed I can update the changelog and work on a new release.

@Achimh3011
Copy link
Contributor

Thx for the heads-up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants