Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't forget to set .davclient in DAVResponse #323

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

sobolevn
Copy link
Contributor

DAVResponse already has class-level davclient = None set, looks like it is not set on instance-level by accident.

`DAVResponse` already has class-level `davclient = None` set, looks like it is not set on instance-level by accident.
@tobixen tobixen added this pull request to the merge queue Jul 20, 2023
Merged via the queue into python-caldav:master with commit 2b8e99d Jul 20, 2023
@tobixen
Copy link
Member

tobixen commented Jul 20, 2023

This classifies as a bugfix, though not a critical one since DAVResponse.davclient is not used anywhere. It's related to pull request #300. I think I will refactor a bit and replace DAVResponse.huge_tree with DAVResponse.davclient.huge_tree.

Edited: I will leave things as they are - since self.davclient can be None, it's easier to just leave self.huge_tree as a separate instance variable.

@tobixen
Copy link
Member

tobixen commented Jul 20, 2023

(hence I will not release any 1.3.7 today. 1.3.6 is still considered good)

tobixen added a commit that referenced this pull request Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants