feat: handle if TYPE_CHECKING block.
#65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterschutt
commented
Mar 28, 2024
| @@ -162,7 +162,7 @@ def handle_import(self, node: Union[ast.Import, ast.ImportFrom]) -> None: | |||
| if not node.col_offset and node.end_lineno > self.last_import: # type: ignore[union-attr] | |||
| self.last_import = node.end_lineno # type: ignore[union-attr] | |||
| else: | |||
| if not node.col_offset and node.lineno > self.last_import: | |||
| if node.lineno > self.last_import: | |||
There was a problem hiding this comment.
I removed the offset condition b/c the type check imports are offset - I expected this might break a test or two but it didn't (at least not in my local runs - ci still running so I might have gone the early crow!).
There was a problem hiding this comment.
I'm not really sure why the check was there. Perhaps I was being overly cautious.
Updates the `last_import` line num for import lines that occur within an `if TYPE_CHECKING` block.
domdfcoding
force-pushed
the
handle-if-type-checking-block
branch
from
e8193a8 to
16e715f
Compare
domdfcoding
approved these changes
Mar 28, 2024
domdfcoding
force-pushed
the
handle-if-type-checking-block
branch
from
16e715f to
73e4c49
Compare
repo-helper
bot
added
the
🤖 automerge
|
Thanks @domdfcoding! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are experiencing an issue where the
__all__declaration gets positioned between runtime and type checking imports. E.g.,So I've slapped this together as a PoC.
The PR updates visitor so that the
last_importis updated for import lines that occur within anif TYPE_CHECKINGblock.I've not done any ast stuff before, so don't really know if what I've added here is a good way to go about it, also how far I should go with tests. Any advice appreciated.