Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor out nd_nomonths and nt_nomonths #109

Merged
merged 1 commit into from
Apr 13, 2023

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Apr 13, 2023

Clean up some redundant helper functions and test production code directly.

@hugovk hugovk added changelog: skip Exclude PR from release draft testing Unit tests, linting, CI, etc. labels Apr 13, 2023
@codecov-commenter
Copy link

codecov-commenter commented Apr 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.06%. Comparing base (0de0fc6) to head (63680b5).
Report is 146 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #109      +/-   ##
==========================================
- Coverage   99.06%   99.06%   -0.01%     
==========================================
  Files           9        9              
  Lines         749      745       -4     
==========================================
- Hits          742      738       -4     
  Misses          7        7              
Flag Coverage Δ
macos-latest 97.85% <100.00%> (-0.02%) ⬇️
ubuntu-latest 97.85% <100.00%> (-0.02%) ⬇️
windows-latest 95.97% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hugovk hugovk merged commit 7e20f6e into python-humanize:main Apr 13, 2023
@hugovk hugovk deleted the refactor-tests branch April 13, 2023 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: skip Exclude PR from release draft testing Unit tests, linting, CI, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants