Fix non-numeric port number bug (addresses #180) #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenballus
changed the title
kenballus
changed the title
|
Addresses #180 |
mahmoud
reviewed
Feb 8, 2023
…thon. changed an error message. fixed negative default port bug
mahmoud
approved these changes
Feb 10, 2023
|
Any update on this? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't supposed to work:
This patch ensures that only valid port strings are accepted.
(The root cause of this is that port numbers are parsed using
int. Both cpython and rfc3986 also had this bug.)