Fix caching issues which render remote ref caching ineffective #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also set B019 as ignored.
The schema loader is asked to retrieve a validator per instance, in order to support the interface of metaschema evaluation. However, this results in a complete rebuild of the validator even when there is one schema being used for many instances (as in the `--schemafile` usage mode). Introducing an LRU cache on the validator builder results in the same validator being reused (and is sensitive to changes in settings/parameters). Additionally fix a bug in the remote ref download caching in which the key used for lookup was incorrect, rendering the cache completely ineffective. A new regression test confirms that the caching is fully effective by only observing the number of requests made by the program over "N" instancefiles, where N>=1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #463