Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable checking .renovaterc.json5 files with pre-commit hook #491

Merged
merged 3 commits into from
Oct 2, 2024

Conversation

tpansino
Copy link
Contributor

@tpansino tpansino commented Oct 1, 2024

Adjust pre-commit hook file regex to allow for .json5 extensions, as these are valid for .renovaterc config files.

@sirosen
Copy link
Member

sirosen commented Oct 1, 2024

.renovaterc also needs to be supported as a filename, which is why CI is failing on the modified regex.

I suggest splitting .renovaterc and .renovaterc.(json|json5) into separate lines in the pattern. That also removes any need for the ?, since .renovaterc. is not a valid pattern.

Thanks for the contribution!

@tpansino
Copy link
Contributor Author

tpansino commented Oct 2, 2024

My apologies, I should have caught that.

@sirosen
Copy link
Member

sirosen commented Oct 2, 2024

I made a minor change to reflect the new regex in the catalog (which is used to generate the hook config), and this is good to go. I'll make sure to add credit in the changelog for you as well. Thanks again!

@sirosen sirosen merged commit b77d04f into python-jsonschema:main Oct 2, 2024
23 checks passed
sirosen added a commit that referenced this pull request Oct 2, 2024
@tpansino
Copy link
Contributor Author

tpansino commented Oct 2, 2024

Thank you for being so prompt and making the contribution process easy!

@tpansino tpansino deleted the patch-1 branch October 2, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants