Adopt typing information from typeshed (PEP-561) #964
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoids problems with mypy by officially declaring the library as typed and copies the current type information from types-jsonschema. From now on the library itself is typed and we will be able to ensure that this types are correct.
for more information, see https://pre-commit.ci
|
@ssbarnea to save you some time I'm going to close this I think. A PR of 400+ lines touching 13 files doesn't meet any definition of "small" that I mentioned in the comment. Separately it seems @sirosen isn't in agreement neither with the proposal to copy things in this PR nor that the original report from #963, so you need to discuss that. More generally, I think you need to pay closer attention to reading comments carefully and making sure there's buy-in before spinning wheels. #963 itself was a good sign of not paying attention to what was previously discussed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids problems with mypy by officially declaring the library as typed while copying the current type information from types-jsonschema.
From now on the library itself is typed and we will be able to ensure that this types are correct and always in sync with each version of the library.
Closes: #963