Catch mypy diagnostics which omit start column/end ranges #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rchl
reviewed
Nov 3, 2023
This commit adds a second line-regexp that catches mypy diagnostics which only include a starting line but have no column or end marker (i.e. --warn-unused-ignores).
Co-authored-by: Rafał Chłodnicki <rchl2k@gmail.com>
|
This has been fixed already and is not your fault. I did a quick rebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few mypy diagnostics which currently slip through pylsp-mypy's reporting because even with the
--show-column-numbersand--show-error-endthose messages do not include a full column and end range.A good example is the output of
--warn-unused-ignores:src/MainWindow.py:30: error: Unused "type: ignore[name-defined]" comment [unused-ignore]This commit adds a second line-regexp that catches mypy diagnostics which only include a starting line but have no column or end marker and maps them to an error in the first column of that line.