Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .flake8 to the discovery paths #219

Closed
m0wer opened this issue Jun 14, 2022 · 4 comments · Fixed by #233
Closed

Add .flake8 to the discovery paths #219

m0wer opened this issue Jun 14, 2022 · 4 comments · Fixed by #233
Milestone

Comments

@m0wer
Copy link

m0wer commented Jun 14, 2022

Currenlty README.md states that flake8 configuration is looked for in ~/.config/flake8, setup.cfg, tox.ini and flake8.cfg. Why isn't .flake8 supported?

@ccordoba12
Copy link
Member

Probably because the author of the flake8 plugin forgot to do it. But you're welcome to send us a pull request to add support for it.

@m0wer
Copy link
Author

m0wer commented Jun 14, 2022 via email

@ccordoba12
Copy link
Member

The server does the discovery.

@lcheylus
Copy link
Contributor

lcheylus commented Jun 28, 2022

The documentation about Flake8 plugin is wrong : according to pylsp/config/flake8_conf.py, Flake8 configuration is looked for in .flake8, setup.cfg and tox.ini :

CONFIG_KEY = 'flake8'
PROJECT_CONFIGS = ['.flake8', 'setup.cfg', 'tox.ini']

Moreover Flake8 4.0 does not read anymore its configuration in ~/.config/flake8 but only in .flake8, setup.cfg and tox.ini in a project directory (see https://flake8.pycqa.org/en/latest/user/configuration.html).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants