Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add notebooks suppport to pylsp #389

Merged
merged 27 commits into from
Aug 9, 2023
Merged

Add notebooks suppport to pylsp #389

merged 27 commits into from
Aug 9, 2023

Commits on Jun 5, 2023

  1. README.md

    @tkrabel-db
    tkrabel-db committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    70076fa View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2023

  1. Add notebook support 

    Support notebookDocument/didOpen and textDocument/publishDiagnostics on a notebook document
    @tkrabel-db
    tkrabel-db committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    ba0f9ad View commit details
    Browse the repository at this point in the history

  2. Add example messages for reference

    @tkrabel-db
    tkrabel-db committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    d5bf4f9 View commit details
    Browse the repository at this point in the history

  3. lsp_types: add DocumentUri and use correctly

    @tkrabel-db
    tkrabel-db committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    78233c7 View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2023

  1. add diagnostics support

    @tkrabel-db
    tkrabel-db committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    09d6879 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2023

  1. support editing, adding, and removing cells

    @tkrabel-db
    tkrabel-db committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    500e120 View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2023

  1. add unit tests for notebook document messages

    @tkrabel-db
    tkrabel-db committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    b407a31 View commit details
    Browse the repository at this point in the history

  2. add test_notebook_document

    @tkrabel-db
    tkrabel-db committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    53e4ad6 View commit details
    Browse the repository at this point in the history

  3. fix unit tests and pylint

    @tkrabel-db
    tkrabel-db committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    c891cf0 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2023

  1. fix pytest test_notebook_document.py

    @tkrabel-db
    tkrabel-db committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    3dcaf9f View commit details
    Browse the repository at this point in the history

  2. Fix pylint issues: 

    too-many-public-methods, dangerous-default-value, unused-import, too-many-locals, redefined-outer-name
    @tkrabel-db
    tkrabel-db committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    ab3bcee View commit details
    Browse the repository at this point in the history

  3. support notebookDocument__did_close

    @tkrabel-db
    tkrabel-db committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    2dd7165 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2023

  1. Add notebookDocumentSync to capabilities

    @tkrabel-db
    tkrabel-db committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    7722239 View commit details
    Browse the repository at this point in the history

  2. Add notebookDocumentSync to capabilities

    @tkrabel-db
    tkrabel-db committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    6c00bfc View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2023

  1. fix: publishDiagnostics line starts at line 0

    @tkrabel-db
    tkrabel-db committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    60517c1 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2023

  1. fix: publishDiagnostics starts at 0 and newlines are counted correctly

    @tkrabel-db
    tkrabel-db committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    ecc27ee View commit details
    Browse the repository at this point in the history

  2. fix: publishDiagnostics starts at 0 and newlines are counted correctly

    @tkrabel-db
    tkrabel-db committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    25cdfab View commit details
    Browse the repository at this point in the history

  3. fix: publishDiagnostics starts at 0 and newlines are counted correctly

    @tkrabel-db
    tkrabel-db committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    2b35c95 View commit details
    Browse the repository at this point in the history

  4. fix: publishDiagnostics starts at 0 and newlines are counted correctly

    @tkrabel-db
    tkrabel-db committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    69a1621 View commit details
    Browse the repository at this point in the history

  5. fix: publishDiagnostics starts at 0 and newlines are counted correctly

    @tkrabel-db
    tkrabel-db committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    1e9a51f View commit details
    Browse the repository at this point in the history

  6. fix: publishDiagnostics starts at 0 and newlines are counted correctly

    @tkrabel-db
    tkrabel-db committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    4f140da View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2023

  1. feat: close cell if deleted

    @tkrabel-db
    tkrabel-db committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    e79bbb2 View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2023

  1. skip tests on windows as it's flaky on py3.7

    @tkrabel-db
    tkrabel-db committed Jul 22, 2023
    Configuration menu
    Copy the full SHA
    ce9f458 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2023

  1. fix test_notebook_document__did_change: need to wait for 2 calls to d… 

    …iagnostics notification since the first call is a n empty diagnostics for the closed cell
    @tkrabel-db
    tkrabel-db committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    5434d1f View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2023

  1. Update test/data/publish_diagnostics_message_examples/example_1.json 

    Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>
    @tkrabel-db @ccordoba12
    tkrabel-db and ccordoba12 authored Jul 29, 2023
    Configuration menu
    Copy the full SHA
    ceb193d View commit details
    Browse the repository at this point in the history

  2. remove aliases

    @tkrabel-db
    tkrabel-db committed Jul 29, 2023
    Configuration menu
    Copy the full SHA
    e7df839 View commit details
    Browse the repository at this point in the history

  3. address comments

    @tkrabel-db
    tkrabel-db committed Jul 29, 2023
    Configuration menu
    Copy the full SHA
    2dd05b7 View commit details
    Browse the repository at this point in the history