-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added reading of earlier ImageMagick PNG EXIF data #4471
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radarhere
changed the title
Added reading of earlier ImageMagick EXIF data
Added reading of earlier ImageMagick PNG EXIF data
Mar 13, 2020
radarhere
force-pushed
the
exif_imagemagick
branch
from
March 13, 2020 13:05
747068c
to
ca5a81e
Compare
We could use pytest's parametrize on this test. Before def test_exif(self):
for test_file in (
"Tests/images/exif.png", # With an EXIF chunk
"Tests/images/exif_imagemagick.png", # With an ImageMagick zTXt chunk
):
with Image.open(test_file) as im:
exif = im._getexif()
assert exif[274] == 1 After @pytest.mark.parametrize(
"test_file",
[
"Tests/images/exif.png", # With an EXIF chunk
"Tests/images/exif_imagemagick.png", # With an ImageMagick zTXt chunk
],
)
def test_exif(self, test_file):
with Image.open(test_file) as im:
exif = im._getexif()
assert exif[274] == 1 One benefit is it (eg. |
Sounds reasonable. Done. |
Thanks! |
This was referenced Mar 6, 2021
This was referenced Mar 17, 2021
Bump pillow from 4.0.0 to 7.1.0 in /study_material/intro-to-tensorflow
tiandiao123/deep_learning#121
Merged
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4460
Before 'eXIf' chunks became part of the PNG specification, ImageMagick stored EXIF data in a zTXt chunk. As a zTXt chunk, it is read into Pillow's
info
dictionary as "Raw profile type exif".So this PR suggests reading that data as a fallback, if an eXIf chunk is not present.
Installing ImageMagick-7.0.6-0, I ran
convert
over Tests/images/exif.png and created an image with the zTXt chunk.When reading, I skip the first two lines - see the corresponding ImageMagick code https://github.com/ImageMagick/ImageMagick/blob/9caa8b0c4269163def2ce0fa6ff1754ec0c234d2/coders/png.c#L7911-L7921