Winbuild: Enable FT_CONFIG_OPTION_USE_HARFBUZZ #4915
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have finally figured out how to resolve the circular dependency between FreeType and HarfBuzz on Windows.
From
ftoption.h
:While I was not able to find a font and text combination that shows a difference, if such a combination exists, someone using these scripts locally or downloading GHA artifacts could benefit from this.
The difference to compile times is imperceptible,
_imagingft.cp37-win_amd64.pyd
is 0.6MB larger, the GHA artifact increases from 13MB to 15.2MB (17%). I don't expect this to go over the (unspecified) GHA limit, but there is an action to remove old artifacts before the 90 day timeout if necessary: https://github.com/c-hive/gha-remove-artifacts