Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Winbuild: Enable FT_CONFIG_OPTION_USE_HARFBUZZ #4915

Merged
merged 1 commit into from
Sep 19, 2020

Conversation

nulano
Copy link
Contributor

@nulano nulano commented Sep 11, 2020

I have finally figured out how to resolve the circular dependency between FreeType and HarfBuzz on Windows.

From ftoption.h:

FreeType uses the HarfBuzz library to improve auto-hinting of OpenType fonts. If available, many glyphs not directly addressable by a font's character map will be hinted also.

Define this macro if you want to enable this 'feature'.

While I was not able to find a font and text combination that shows a difference, if such a combination exists, someone using these scripts locally or downloading GHA artifacts could benefit from this.

The difference to compile times is imperceptible, _imagingft.cp37-win_amd64.pyd is 0.6MB larger, the GHA artifact increases from 13MB to 15.2MB (17%). I don't expect this to go over the (unspecified) GHA limit, but there is an action to remove old artifacts before the 90 day timeout if necessary: https://github.com/c-hive/gha-remove-artifacts

@hugovk hugovk merged commit c236740 into python-pillow:master Sep 19, 2020
@hugovk
Copy link
Member

hugovk commented Sep 19, 2020

Thanks!

@nulano nulano deleted the ft-hb branch September 19, 2020 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants