Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin to Python 3.9.16-1 #7762

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Pin to Python 3.9.16-1 #7762

merged 1 commit into from
Jan 31, 2024

Conversation

radarhere
Copy link
Member

Our Cygwin jobs have been failing for several days - https://github.com/python-pillow/Pillow/actions/workflows/test-cygwin.yml

In looking at a discussion over at NumPy about this, there was a suggestion to use the egor-tension/setup-cygwin action and pin to Python 3.9.16-1 - numpy/numpy#25708 (comment)

@hugovk
Copy link
Member

hugovk commented Jan 30, 2024

Sounds like a good idea. Has this been reported upstream to Cygwin?

@radarhere
Copy link
Member Author

I've just posted in the Cygwin mailing list - https://cygwin.com/pipermail/cygwin/2024-January/255273.html

@hugovk
Copy link
Member

hugovk commented Jan 30, 2024

So before, both 3.8 and 3.9 jobs were timing out: https://github.com/python-pillow/Pillow/actions/runs/7705171752

Now, we've switched to egor-tensin/setup-cygwin but does python39=3.9.16-1 mean we install that for both 3.8 and 3.9 jobs? But we're still testing with either 3.8 or 3.9 for the relevant job.

https://github.com/python-pillow/Pillow/actions/runs/7708554081

@radarhere
Copy link
Member Author

python39 is already being installed in the 3.8 job, as some sort of dependency - https://github.com/python-pillow/Pillow/actions/runs/7705171752/job/20998682687#step:4:362. It's just explicit rather than implicit now so that the version can be pinned.

@radarhere
Copy link
Member Author

This was reverted in #7880

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants