Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate eval(), replacing it with lambda_eval() and unsafe_eval() #7927

Merged
merged 6 commits into from
Apr 1, 2024
Merged

Deprecate eval(), replacing it with lambda_eval() and unsafe_eval() #7927

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
27b10c4
Deprecate eval(), replacing it with lambda_eval() and unsafe_eval()
radarhere Mar 25, 2024
a7e82cb
Removed "In the current version"
radarhere Mar 25, 2024
f932cb8
Added danger alerts
radarhere Mar 25, 2024
f6596d5
Added release notes and document deprecation
radarhere Mar 25, 2024
8f3860c
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Apr 1, 2024
f5eeeac
Name as 'options' in lambda_eval and unsafe_eval, but '_dict' in depr…
hugovk Apr 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Tests/helper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,9 @@ def assert_image_similar(

diff = 0
for ach, bch in zip(a.split(), b.split()):
chdiff = ImageMath.eval("abs(a - b)", a=ach, b=bch).convert("L")
chdiff = ImageMath.lambda_eval(
lambda args: abs(args["a"] - args["b"]), a=ach, b=bch
).convert("L")
diff += sum(i * num for i, num in enumerate(chdiff.histogram()))

ave_diff = diff / (a.size[0] * a.size[1])
Expand Down
4 changes: 3 additions & 1 deletion Tests/test_image_reduce.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,9 @@ def assert_compare_images(

bands = ImageMode.getmode(a.mode).bands
for band, ach, bch in zip(bands, a.split(), b.split()):
ch_diff = ImageMath.eval("convert(abs(a - b), 'L')", a=ach, b=bch)
ch_diff = ImageMath.lambda_eval(
lambda args: args["convert"](abs(args["a"] - args["b"]), "L"), a=ach, b=bch
)
ch_hist = ch_diff.histogram()

average_diff = sum(i * num for i, num in enumerate(ch_hist)) / (
Expand Down
214 changes: 0 additions & 214 deletions Tests/test_imagemath.py
View file
Open in desktop

This file was deleted.

Loading
Loading