Move x86 jobs to GHA #169
Move x86 jobs to GHA #169
Conversation
| # Uncomment to get SSH access for testing | ||
| # - name: Setup tmate session | ||
| # if: failure() | ||
| # uses: mxschmitt/action-tmate@v3 |
There was a problem hiding this comment.
I found this action to be invaluable in debugging the macOS build, as I do not have any other way of using a macOS machine.
| build-latest: | ||
| name: ${{ matrix.python }} ${{ matrix.os-name }} ${{ matrix.platform }} latest | ||
| runs-on: ${{ matrix.os }} | ||
| if: "!startsWith(github.ref, 'refs/tags/')" |
There was a problem hiding this comment.
Latest only runs on non-tagged builds as a second job. This requires duplicating the build matrix.
This is not as necessary on GHA as on Travis due to the speed difference, but I tried to match the Travis jobs as closely as possible for now.
I also put PyPy first to give it a head-start on macOS, it is by far the slowest job at ~15m.
| - name: Upload Release | ||
| uses: fnkr/github-action-ghr@v1.3 | ||
| env: | ||
| GHR_PATH: . | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} |
There was a problem hiding this comment.
The "official" actions for this by GHA are no longer actively supported, actions/upload-release-asset#58 (comment). They also break badly if a release already exists, and don't support wildcards.
Testing, I have found this action to work well, the only issue is if a successful build is re-run for whatever reason, with it failing to upload duplicate filenames. The ${{ secrets.GITHUB_TOKEN }} is provided automatically.
|
|
||
| ORIGINAL_CPPFLAGS=$CPPFLAGS | ||
| CPPFLAGS="" | ||
| fi |
There was a problem hiding this comment.
I have found that GHA no longer seems to require #104.
|
|
||
| if [[ "$TRAVIS_OS_NAME" == "osx" ]]; then | ||
| # these cause a conflict with built webp and libtiff | ||
| brew remove --ignore-dependencies webp zstd xz libtiff |
There was a problem hiding this comment.
This resolves #133 which reappears on GHA.
|
I just noticed that the GHA macOS PyPy test doesn't have ImageTk: https://github.com/nulano/pillow-wheels/runs/1328473365?check_suite_focus=true#step:4:6002 Edit: Added |
|
Thank you for this! First glance looks good, will take a closer look hopefully this week. So this reduces build time from ~1h 20m to (~30m + ~26m in parallel => ) ~30m 👍 |
|
You might find dbhi/qus useful for migrating ARM jobs to GHA too. |
Travis currently uses I guess it's fine to build GHA on Xcode 12.0.1 as it also sets Should we also pin to an Xcode version for stability? |
It might be a good idea to actually test on an older machine, if anyone has access to one.
GHA periodically remove older versions (e.g. actions/runner-images#1688), so I'm not sure if pinning will cause more issues or less. Also, IIUC the Travis images are different for each XCode version, while on GHA it is always the same image, just a different XCode version. My thinking is that it might be better to leave it at default until a problem comes up. |
|
Oldest I have is 10.13.6 High Sierra, installed fine for Python 3.7.2 (using wheels.zip from https://github.com/nulano/pillow-wheels/actions/runs/350516695) and a quick sanity test was good: >>> from PIL import Image
>>> im = Image.new("RGB", (300, 30), "#fff")
>>> im.show()Also good on 10.14.6 Mojave with Python 3.9.0. Let's merge. Thanks! |
This PR moves the x86 and x86_64 builds to GHA (needs to be manually enabled it seems). Unlike Travis CI, which has 5 parallel jobs, and the .org version has been slow lately, GHA gives 20 parallel jobs (max 5 macOS).
The GHA build of 20 Ubuntu and 10 macOS jobs takes ~30m, barely slower than the remaining 8 Arm64 builds on Travis.org (~26m) if queued immediately. Note that Arm64 seems to have a separate queue and is less affected by the slowdown.
Also adds a Linux 32-bit PyPy wheel, as I do not see a reason it was not added in #153.
The macOS build uses the default XCode, currently 12.0.1. actions/runner-images#1712 shows how to pin to a specific version if necessary. XCode 10.3 is the oldest version currently available: https://github.com/actions/virtual-environments/blob/main/images/macos/macos-10.15-Readme.md#xcode
More details are posted per-line below.