This repository has been archived by the owner on Oct 8, 2024. It is now read-only.
Build arm64 wheel #185
Merged
Build arm64 wheel #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, let's do it! |
|
You don't need macos 11.0. See https://github.com/MacPython/openblas-libs/blob/master/.github/workflows/multibuild.yml#L74-L77 |
|
@isuruf are you just letting us know, or suggesting a change? I would have thought it was simpler to use macos 11.0? The next release of Pillow isn't for another two months, and I would hope that the pool would be usable by then. |
|
Just a FYI |
|
An arm64 wheel has now been uploaded as part of Pillow 8.1.1 |
|
On sonoma 14.3.1. could ot install via pillow recommended install. Seemed to install after running brew install libtiff libjpeg webp little-cms2 |
|
Please open a detailed issue at https://github.com/python-pillow/Pillow/issues if you'd like us to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps python-pillow/Pillow#5093
Updating multibuild to include https://github.com/matthew-brett/multibuild/pull/383 and https://github.com/matthew-brett/multibuild/pull/384, this PR adds a job to build an arm64 wheel on x86_64 (actions/runner#805 would indicate that running arm64 directly is not an option).
Some notes
Most importantly though, actions/runner-images#2486 states that macOS 11 is currently limited to repositories that have used it before - so it will not work here. However, my fork of pillow-wheels has used it before, so it passes.
So while this PR will fail for now, if the code changes in this PR are approved, then a wheel generated by my fork could be uploaded to PyPI to fix python-pillow/Pillow#5093 for the moment.
Pillow-8.1.0-cp39-cp39-macosx_11_0_arm64.whl.zip