Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix parsing PEP 508 url requirements with extras #345

Merged
merged 1 commit into from
May 7, 2022
Merged

fix parsing PEP 508 url requirements with extras #345

merged 1 commit into from
May 7, 2022

Conversation

abn
Copy link
Member

@abn abn commented May 6, 2022

Discovered this issue while implementing python-poetry/poetry#5554.

@abn abn requested a review from a team May 6, 2022 21:56
@sonarcloud
Copy link

sonarcloud bot commented May 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.5% 1.5% Duplication

@neersighted neersighted merged commit dee2c33 into python-poetry:master May 7, 2022
@abn abn deleted the fix-pep-508-url-parsing branch May 7, 2022 17:20
@finswimmer finswimmer mentioned this pull request May 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neersighted neersighted neersighted approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abn @neersighted