fix(factory): unwrap config to not end up with tomlkit instances
#445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkniewallner
force-pushed
the
fix/unwrap-toml-config
branch
from
eb6f02f
to
20414ba
Compare
3 tasks
mkniewallner
force-pushed
the
fix/unwrap-toml-config
branch
from
20414ba
to
e091fcf
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
mkniewallner
changed the title
tomlkit instancestomlkit instances
This was referenced Sep 19, 2022
|
@mkniewallner, can you enlighten me as to why unwrapping the config would ultimately prevent the extra indentation from appearing in our |
|
Because the subclass of If you'd like to learn more about the architecture of Poetry/poetry-core/Cleo/Tomlkit, I suggest reaching out via Discord 😄 |
|
Closing, since #483 was merged and we no longer use tomlkit in poetry-core |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves python-poetry/poetry/issues/6201.
WIP for now, since we need to measure the impacts of this change, and this is missing tests.