Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

strict flake8-type-checking #508

Merged
merged 3 commits into from
Oct 23, 2022
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .flake8
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ ban-relative-imports = True
format-greedy = 1
inline-quotes = double
enable-extensions = TC, TC1
type-checking-exempt-modules = typing, typing-extensions
strict-type-checking = true
dimbleby marked this conversation as resolved.
Show resolved Hide resolved
eradicate-whitelist-extend = ^-.*;
extend-ignore =
# E203: Whitespace before ':' (pycqa/pycodestyle#373)
Expand Down
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ repos:
- flake8-quotes==3.3.1
- flake8-simplify==0.19.3
- flake8-tidy-imports==4.8.0
- flake8-type-checking==2.1.2
- flake8-type-checking==2.2.0
- flake8-typing-imports==1.12.0
- flake8-use-fstring==1.4
- pep8-naming==0.13.1
Expand Down
2 changes: 1 addition & 1 deletion src/poetry/core/masonry/utils/helpers.py
Original file line number Diff line number Diff line change
Expand Up @@ -80,4 +80,4 @@ def distribution_name(name: NormalizedName) -> DistributionName:
respectively), and replace dash (-) characters with underscore (_) characters ...
"""
distribution_name = name.replace("-", "_")
return cast(DistributionName, distribution_name)
return cast("DistributionName", distribution_name)
2 changes: 1 addition & 1 deletion tests/packages/test_directory_dependency.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ def _test_directory_dependency_pep_508(
)

assert dep.is_directory()
dep = cast(DirectoryDependency, dep)
dep = cast("DirectoryDependency", dep)
assert dep.name == name
assert dep.path == path
assert dep.to_pep_508() == (pep_508_output or pep_508_input)
Expand Down
2 changes: 1 addition & 1 deletion tests/packages/test_file_dependency.py
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ def _test_file_dependency_pep_508(
dep.marker = marker

assert dep.is_file()
dep = cast(FileDependency, dep)
dep = cast("FileDependency", dep)
assert dep.name == name
assert dep.path == path
assert dep.to_pep_508() == (pep_508_output or pep_508_input)
Expand Down
10 changes: 5 additions & 5 deletions tests/packages/test_main.py
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ def test_dependency_from_pep_508_with_git_url() -> None:

assert dep.name == "django-utils"
assert dep.is_vcs()
dep = cast(VCSDependency, dep)
dep = cast("VCSDependency", dep)
assert dep.vcs == "git"
assert dep.source == "ssh://git@corp-gitlab.com/corp-utils.git"
assert dep.reference == "1.2"
Expand All @@ -202,7 +202,7 @@ def test_dependency_from_pep_508_with_git_url_and_subdirectory() -> None:

assert dep.name == "django-utils"
assert dep.is_vcs()
dep = cast(VCSDependency, dep)
dep = cast("VCSDependency", dep)
assert dep.vcs == "git"
assert dep.source == "ssh://git@corp-gitlab.com/corp-utils.git"
assert dep.reference == "1.2"
Expand All @@ -219,7 +219,7 @@ def test_dependency_from_pep_508_with_git_url_and_comment_and_extra() -> None:

assert dep.name == "poetry"
assert dep.is_vcs()
dep = cast(VCSDependency, dep)
dep = cast("VCSDependency", dep)
assert dep.vcs == "git"
assert dep.source == "https://github.com/python-poetry/poetry.git"
assert dep.reference == "b;ar;"
Expand All @@ -233,7 +233,7 @@ def test_dependency_from_pep_508_with_url() -> None:

assert dep.name == "django-utils"
assert dep.is_url()
dep = cast(URLDependency, dep)
dep = cast("URLDependency", dep)
assert dep.url == "https://example.com/django-utils-1.0.0.tar.gz"


Expand All @@ -247,7 +247,7 @@ def test_dependency_from_pep_508_with_url_and_subdirectory() -> None:

assert dep.name == "django-utils"
assert dep.is_url()
dep = cast(URLDependency, dep)
dep = cast("URLDependency", dep)
assert dep.url == "https://example.com/django-utils-1.0.0.tar.gz"
assert dep.directory == "django"

Expand Down
8 changes: 4 additions & 4 deletions tests/packages/test_package.py
Original file line number Diff line number Diff line change
Expand Up @@ -350,7 +350,7 @@ def test_to_dependency_for_directory() -> None:
assert dep.constraint == package.version
assert dep.features == frozenset({"bar", "baz"})
assert dep.is_directory()
dep = cast(DirectoryDependency, dep)
dep = cast("DirectoryDependency", dep)
assert dep.path == path
assert dep.source_type == "directory"
assert dep.source_url == path.as_posix()
Expand All @@ -373,7 +373,7 @@ def test_to_dependency_for_file() -> None:
assert dep.constraint == package.version
assert dep.features == frozenset({"bar", "baz"})
assert dep.is_file()
dep = cast(FileDependency, dep)
dep = cast("FileDependency", dep)
assert dep.path == path
assert dep.source_type == "file"
assert dep.source_url == path.as_posix()
Expand All @@ -394,7 +394,7 @@ def test_to_dependency_for_url() -> None:
assert dep.constraint == package.version
assert dep.features == frozenset({"bar", "baz"})
assert dep.is_url()
dep = cast(URLDependency, dep)
dep = cast("URLDependency", dep)
assert dep.url == "https://example.com/path.tar.gz"
assert dep.source_type == "url"
assert dep.source_url == "https://example.com/path.tar.gz"
Expand All @@ -418,7 +418,7 @@ def test_to_dependency_for_vcs() -> None:
assert dep.constraint == package.version
assert dep.features == frozenset({"bar", "baz"})
assert dep.is_vcs()
dep = cast(VCSDependency, dep)
dep = cast("VCSDependency", dep)
assert dep.source_type == "git"
assert dep.source == "https://github.com/foo/foo.git"
assert dep.reference == "master"
Expand Down
4 changes: 2 additions & 2 deletions tests/test_factory.py
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ def test_create_poetry() -> None:
pendulum = dependencies["pendulum"]
assert pendulum.pretty_constraint == "branch 2.0"
assert pendulum.is_vcs()
pendulum = cast(VCSDependency, pendulum)
pendulum = cast("VCSDependency", pendulum)
assert pendulum.vcs == "git"
assert pendulum.branch == "2.0"
assert pendulum.source == "https://github.com/sdispater/pendulum.git"
Expand All @@ -67,7 +67,7 @@ def test_create_poetry() -> None:
tomlkit = dependencies["tomlkit"]
assert tomlkit.pretty_constraint == "rev 3bff550"
assert tomlkit.is_vcs()
tomlkit = cast(VCSDependency, tomlkit)
tomlkit = cast("VCSDependency", tomlkit)
assert tomlkit.vcs == "git"
assert tomlkit.rev == "3bff550"
assert tomlkit.source == "https://github.com/sdispater/tomlkit.git"
Expand Down