Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic constraint intersection and union #515

Conversation

radoering
Copy link
Member

Fixes and implemenation of previously unsupported variants of intersection and union of generic constraints + complete test coverage.

  • Added tests for changed code.
  • Updated documentation for changed code.

@radoering radoering force-pushed the generic-constraint-intersection-and-union branch from 7408fac to 238a62f Compare November 2, 2022 16:42
@radoering radoering force-pushed the generic-constraint-intersection-and-union branch from 238a62f to 270f466 Compare November 19, 2022 09:59
@radoering radoering requested a review from a team November 19, 2022 10:05
@radoering radoering force-pushed the generic-constraint-intersection-and-union branch from 270f466 to 4c4f817 Compare November 28, 2022 18:55
@radoering radoering force-pushed the generic-constraint-intersection-and-union branch from 4c4f817 to 58c01da Compare December 10, 2022 17:43
@radoering radoering force-pushed the generic-constraint-intersection-and-union branch from 58c01da to 6352285 Compare January 7, 2023 14:29
@radoering radoering force-pushed the generic-constraint-intersection-and-union branch from 6352285 to 1c1e71e Compare January 22, 2023 18:49
@sonarcloud
Copy link

sonarcloud bot commented Jan 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
1.0% 1.0% Duplication

Copy link
Member

@Secrus Secrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@radoering radoering merged commit 14f98fb into python-poetry:main Jan 24, 2023
@radoering radoering mentioned this pull request Jan 24, 2023
@radoering radoering deleted the generic-constraint-intersection-and-union branch November 24, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants