Optionally use resolved references in to_pep_508 #603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
radoering
requested changes
Jun 9, 2023
There was a problem hiding this comment.
I have to say I was not thrilled about the change but since I don't see a better solution than adding a new parameter and this (finally) will solve a valid bug in the export plugin, let's go.
I have no idea how to update the documentation since by inspecting this library I found no documentation for any of the internal python functions.
It's just a reminder to think about it. There is nothing to update here.
radoering
reviewed
Jun 12, 2023
radoering
reviewed
Jun 13, 2023
Co-authored-by: Randy Döring <30527984+radoering@users.noreply.github.com>
radoering
approved these changes
Jun 13, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related-to: python-poetry/poetry-plugin-export#35
Well this pull request doesn't actually solve the issue linked above. But it is necessary to be able to solve it.
I've modified the
to_pep_508function to return resolved references if called with the optional argumentresolved=True. The default of this argument isFalsein order to not make any backward incompatible changes that might adversely affect other code also making use of theto_pep_508function.I have no idea how to update the documentation since by inspecting this library I found no documentation for any of the internal python functions.