fix(git): experimental.system-git-client can't be set using environ…

…ment variable Resolves: #6722
python-poetry · Oct 12, 2022 · 0b71e43 · 0b71e43
1 parent 0ffe91c
commit 0b71e43
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/src/poetry/vcs/git/backend.py b/src/poetry/vcs/git/backend.py
@@ -366,8 +366,8 @@ def _clone_submodules(cls, repo: Repo) -> None:
     def is_using_legacy_client() -> bool:
         from poetry.config.config import Config
 
-        legacy_client: bool = (
-            Config.create().get("experimental", {}).get("system-git-client", False)
+        legacy_client: bool = Config.create().get(
+            "experimental.system-git-client", False
         )
         return legacy_client
 

diff --git a/tests/integration/test_utils_vcs_git.py b/tests/integration/test_utils_vcs_git.py
@@ -111,6 +111,13 @@ def remote_default_branch(remote_default_ref: bytes) -> str:
     return remote_default_ref.decode("utf-8").replace("refs/heads/", "")
 
 
+# Regression test for https://github.com/python-poetry/poetry/issues/6722
+def test_use_system_git_client_from_environment_variables():
+    os.environ["POETRY_EXPERIMENTAL_SYSTEM_GIT_CLIENT"] = "true"
+
+    assert Git.is_using_legacy_client()
+
+
 def test_git_local_info(
     source_url: str, remote_refs: FetchPackResult, remote_default_ref: bytes
 ) -> None: