Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Installer Installs PREVIEW release even when POETRY_PREVIEW=0 #2977

Closed
3 tasks done
adawalli opened this issue Sep 25, 2020 · 1 comment · Fixed by #2978
Closed
3 tasks done

Installer Installs PREVIEW release even when POETRY_PREVIEW=0 #2977

adawalli opened this issue Sep 25, 2020 · 1 comment · Fixed by #2978
Labels
kind/bug Something isn't working as expected

Comments

@adawalli
Copy link
Contributor

  • I am on the latest Poetry version.

  • I have searched the issues of this repo and believe that this is not a duplicate.

  • If an exception occurs when executing a command, I executed it again in debug mode (-vvv option).

  • OS version and name: MAC OSX 10.15.6, Debian 9/10

  • Poetry version: NA

Issue

The installer is installing 1.1.0rc1 even when POETRY_PREVIEW==0. This will force people to download a preview/RC version prematurely.
@adawalli adawalli added kind/bug Something isn't working as expected status/triage This issue needs to be triaged labels Sep 25, 2020
adawalli added a commit to adawalli/poetry that referenced this issue Sep 25, 2020
@adawalli
Add 'rc' to VERSION_REGEX
da05bd3 
The previous VERSION_REGEX string only checks for 'RC', however, the
latest RC submitted to the poetry project is '1.1.0rc1' which fails the
regex test for allowing installation of PREVIEW releases.

fixes: python-poetry#2977
@adawalli adawalli mentioned this issue Sep 25, 2020
Merged
@abn abn closed this as completed in #2978 Sep 25, 2020
abn pushed a commit that referenced this issue Sep 25, 2020
@adawalli @abn
Add 'rc' to VERSION_REGEX
fa0881d 
The previous VERSION_REGEX string only checks for 'RC', however, the
latest RC submitted to the poetry project is '1.1.0rc1' which fails the
regex test for allowing installation of PREVIEW releases.

fixes: #2977
@abn abn removed the status/triage This issue needs to be triaged label Mar 3, 2022
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 2, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
kind/bug Something isn't working as expected
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add 'rc' to VERSION_REGEX adawalli/poetry
2 participants
@abn @adawalli