-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs Limit Keywords To 5 #4183
Comments
Looking the code, indeed it seems that there is no limit enforced by poetry. PEP 314 also did not constraint the keywords to any specific limit. https://www.python.org/dev/peps/pep-0314/#keywords-optional |
The code does not enforce any limit. Additionally, there is no limit set in PEP 314 ( https://www.python.org/dev/peps/pep-0314/#keywords-optional ) Closes python-poetry#4183
The readme.md also mentions that keywords are up to 5. I made the PR to remove it. #4635 |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Issue
The pyproject docs make the following claim about keywords:
- https://python-poetry.org/docs/pyproject/#keywords
From my testing, this limit is not actually enforced in any way, and I'm not quite sure why it exists. I've asked on the discord server here, and didn't get a conclusive answer.
I deployed this package with 7 keywords from this pyproject.
At no point did anything complain, and all 7 tags show up fine on the pypi page. (For reference, the linked package is converting an already existing package from using setuptools to poetry. The main package has the same 7 tags with no problem.)
I traced this change back to a commit (e907f40) that added a bunch of documentation, and I can't see a clear reason behind the limit.
The text was updated successfully, but these errors were encountered: