-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extras names are incorrectly normalized in poetry-core >= 1.3.0 #6819
Comments
Ah, I just processed that this was |
yep, looks like basically a duplicate of python-poetry/poetry-plugin-export#150 here's a pip bug requesting pep 685 be implemented pypa/pip#11445 I've not looked at the pip code but I can't imagine that the part of pep685 which says "normalize extra names before comparison" can be very hard to do, perhaps someone who is affected by this would like to put together an MR over there |
looks as though this was implemented in However updates in the last couple of days suggest that it's coming imminently, and I'd guess that pip will pick that up in their next release. So IMO poetry should hold firm here. Reverting the change, apart from being tedious, would reintroduce the bugs that it fixed (#6321) - ie it's not obviously making things better - and it looks reasonable to expect that the ecosystem is close to catching up with the specs. |
It's taken somewhat longer than I'd guessed it would, but packaging 22.0 has now been released So I guess that a pip release picking that up will happen in due course, and pip should soon agree with poetry - or rather with PEP685 - about how extras are normalized. |
well it really is taking a while for pip to implement pep 685, pypa/pip#11445 seems to be harder than I'd have guessed. nevertheless there is no poetry bug here and no intention of changing poetry behaviour, might as well close this one out I think |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
-vvv
option) and have included the output below.Issue
This appears to be a regression introduced in poetry-core 1.3.0. I'm opening the issue here because issues are closed on the poetry-core repo.
When using poetry-core >= 1.3.0, names of extras are incorrectly normalized to change
_
to-
, causing their installation to fail:With poetry-core 1.2.0:
The text was updated successfully, but these errors were encountered: