-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Releases 1.8.1 and 1.8.2 on PyPI don't work when installed with_$EXTRA or with-$EXTRA #545
Comments
* The latest release of prospector doesn't ship the with_* extras. See: landscapeio/prospector#545 Change-Id: I6092bf0d5cf2143d216d9bf6a06b166feaa14e1e
Isn't it related to this issue? |
Does |
It looks like it, |
I think we have to upgrade the doc, this is a poetry behavior that will be painful to change. |
This issue also happens when installing from pip. There is a glitch in the doc. Before it was [with _ everything] now it is [with - everything] |
Actually I have to correct myself, although the pip installation works, prospector is not able to run the extra tool though. Repro steps: $ pip install "prospector[with-everything]"
...
$ pip freeze | grep -E '(pyroma|prospector)'
prospector==1.8.1
pyroma==4.1
$ cat prospector.yaml
pyroma:
run: true
$ prospector --profile prospector.yaml test/
Cannot run tool pyroma as support was not installed.
Please install by running 'pip install prospector[with_pyroma]' |
For me, you should publish prospector with on older version of poetry since it is fixed in pip... |
I think you mean we should use an old version of poetry when releasing but I did not understand "this is fixed in pip" @sbrunner ? |
In this issue python-poetry/poetry#6819 |
Thanks for tracking the root cause 👍 So if I understand we should release using an old poetry and wait for the 22.2 release in pip and use the latest poetry only then ? |
* Add python_requires metadata. The latest pyroma does check for its presence and it makes sense to add it to prevent from installing the package on the wrong Python version. * Revert old upper limit for GitPython, there are no more issue with more recent versions. * Set an upper limit for pylint and prospector. A change in pylint broke prospector, but we can't upgrade prospector because of an upstream bug, see: landscapeio/prospector#545 * Split the python auto-formatter test dependencies on their own extra group so that they can be installed alone in the already split virtual environment for the tox envs py3-style and py3-format. This way there are no conflicts between other test dependencies and black and isort. * Add specific style tox environments for each Python version to avoid the CI jobs to pick Python 3.7 that has a pip backtracking issue with the latest versions of the dependencies. Keep the py3-{style,format} environments for ease of use locally and to not break compatibility but make the py3-style one not run automatically in CI. Change-Id: I6ce05223df3bf17e269994ee7501ec16e35c76dd
* Add python_requires metadata. The latest pyroma does check for its presence and it makes sense to add it to prevent from installing the package on the wrong Python version. * Set an upper limit for pylint and prospector. A change in pylint broke prospector, but we can't upgrade prospector because of an upstream bug, see: landscapeio/prospector#545 Change-Id: I2cae1d503639ba35bb0f93515988aff8a207b4f6
@Pierre-Sassoulas I took the liberty to rename the task to be more clear. Do you happen to have an ETA for the resolution of this problem? |
Describe the bug
When trying to install the latest version of Prospector from PyPI
1.8.1
with some extras likewith_everything
orwith_pyroma
a warning is printed and Prospector is installed without the extras.To Reproduce
or
Expected behavior
It should install Prospector with the selected extras.
Environment:
The text was updated successfully, but these errors were encountered: