-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify that name
and version
fields are required in non-package mode if [project]
is used
#10033
Conversation
Reviewer's Guide by SourceryThis PR clarifies that the State diagram for pyproject.toml configuration requirementsstateDiagram-v2
[*] --> ProjectConfig
ProjectConfig --> PackageMode: package mode
ProjectConfig --> NonPackageMode: non-package mode
state PackageMode {
[*] --> RequiredFields
state RequiredFields {
name
version
}
RequiredFields --> OptionalFields
}
state NonPackageMode {
[*] --> CheckProjectSection
CheckProjectSection --> ProjectSectionUsed: using [project]
CheckProjectSection --> AllOptional: not using [project]
state ProjectSectionUsed {
RequiredName: name required
RequiredVersion: version required
}
}
File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @johnthagen - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Deploy preview for website ready! ✅ Preview Built with commit 6345aae. |
…mode if `[project]` is used
Pull Request Check List
Resolves: #10031
Should be merged after this issue is fixed
version
field not required in[project]
table whenpackage-mode = false
#10032Summary by Sourcery
Documentation:
name
andversion
fields are always required if theproject
section is specified.