Add full environment markers support #1142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djetelina
reviewed
May 31, 2019
| @@ -39,6 +39,9 @@ my-package = { path = "../project_with_setup/" } | |||
| # Dir dependency with pyproject.toml | |||
| simple-project = { path = "../simple_project/" } | |||
|
|
|||
| # Dependency with markers | |||
| functools32 = { version = "^3.2.3", markers = "python_version ~= '2.7' and sys_platform == 'win32' or python_version in '3.4 3.5'" } | |||
There was a problem hiding this comment.
Nitpick: This sample made me realize I have no idea how it would resolve. Is it (A and B) or (C), A and (B or C)? I had to go into the PEP and quickly scan it. Including the basics in poetry's documentation in clear examples might be useful.
Stolen from the PEP's tests:
# Should parse as (a and b) or c
"name; os_name=='a' and os_name=='b' or os_name=='c'",
# Overriding precedence -> a and (b or c)
"name; os_name=='a' and (os_name=='b' or os_name=='c')",
# should parse as a or (b and c)
"name; os_name=='a' or os_name=='b' and os_name=='c'",
# Overriding precedence -> (a or b) and c
"name; (os_name=='a' or os_name=='b') and os_name=='c'",And even with those, I'm still a bit unclear on how it works with extras. Perhaps it's not poetry's responsiblity to document this clearly, but it certainly wouldn't hurt.
Closed
2 tasks
2 tasks
2 tasks
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Check List
Up until now, Poetry only supported the
pythonandplatformproperties to specify conditional dependencies. This PR adds support for any environment markers via themarkersproperty.