Respect Python version in bin script #1312
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In particular, this extra documentation covers the Python binary used by the poetry executable.
michielboekhoff
changed the title
3 tasks
|
Thanks @brycedrennan! Apologies for the duplication, I didn't see that - I'll put my thoughts on the PR and on the issue. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the Poetry installer
get-poetry.pyrespect the installing version of Python in installing the~/.poetry/bin/poetryscript.Simply, if
python3is used to install Poetry, then use that as the Python executable to run Poetry as. If it ispython(e.g. Python 2), then usepython.This should fix the issues some people are having in #1257.