Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (git.py): git url's can now contain longer path names (#1746) #1756

Merged

Conversation

finswimmer
Copy link
Member

git url's can now contain longer path names, e.g. projects like in gitlab.

Fixes: #1746

Pull Request Check List

  • Added tests for changed code.
  • Updated documentation for changed code.

@finswimmer finswimmer requested a review from a team December 17, 2019 12:43
@finswimmer finswimmer added the kind/bug Something isn't working as expected label Dec 17, 2019
Copy link
Member

@sdispater sdispater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@sdispater sdispater merged commit 275d09f into python-poetry:master Dec 24, 2019
shenek pushed a commit to shenek/poetry that referenced this pull request Dec 31, 2019
@finswimmer finswimmer deleted the issue-01746-git-subproject branch April 4, 2020 19:02
Copy link

github-actions bot commented Mar 1, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Something isn't working as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding git dependency from subproject failes
2 participants