-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove 'm' and 'd' ABI tags for Python 3.8 wheels #2121
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your first contribution! 🚀
It would be great if you could write a test for this -- one doesn't exist yet but you can put it under tests/masonry/utils
.
I can confirm I faced the exact same issue. Any binary wheel built with Poetry 1.0.5 for Python 3.8 under Windows will have @sdispater @stephsamson this seems like critical issue, with a very simple fix. Would be great if you find some time to review/merge this PR. Btw even |
In principle I could do that, however, I find it a bit hard to get started as I do not know where the |
@koehlma I added some review comment. For testing, you can construct a mocked env with from poetry.utils.env import MockEnv
env = MockEnv(version_info=(3, 8, 0)) |
Here you go. I wrote a test and adapted the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look great. One comment, a good to have.
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Hey everyone,
as of Python 3.8 the
m
andd
ABI flags became obsolete (see 1 and 2). In fact, if present, they do prevent the installation of wheels. However, poetry seems to add those flags anyway. As a result, I cannot install wheels build withpoetry build
on the same system they were built on.This pull request fixes a
RuntimeWarning
if the flags are not present in the environment and prevents the flags from being added to the ABI tag if the Python version is>= 3.8
.Cheers,
Maximilian
Resolves: sdispater/pendulum#456