[Bugfix] Moved access to first element to after the length check #2265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
finswimmer
added
the
area/error-handling
|
@Qu4tro thank you for the fix. Can you also apply the same changes to https://github.com/python-poetry/core/blob/master/poetry/core/masonry/utils/package_include.py please? Also, might be great to have a test case so that we do not regress later. |
2 tasks
|
Done and done. |
abn
approved these changes
Apr 5, 2020
3 tasks
2 tasks
Merged
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey 👋
Quick fix for a problem I was having. My
pyproject.tomltool.poetry.packageswas wrong, but I was getting[IndexError] list index out of rangewhich is not very helpful.Clearing this, helped me get an error message, that was actually helpful:
/home/user/repo/pkg/pkg does not contain any elementIt needs some tests, but still unsure of where to start.