-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve editable installs #2360
Conversation
The latest Poetry on develop now fails (when running
Perhaps related to this PR? Poetry does not print the full stack trace so I don't have more information than this. |
@PetterS Thanks for pointing this out. I stumbled upon this issue this week-end myself and I already have a fix for it that I need to test before making a pull request. I'll let you know when it's ready. |
Cheers! 👍 |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Pull Request Check List
Resolves: #730
Resolves: #2079
Resolves: #2126
Resolves: #2225
Resolves: #2324
This PR improves and makes proper use of the
EditableBuilder
.This change affects the
install
command in two ways:setup.py
file.setup.py
step.For the details of how it's done:
.pth
file in thesite-packages
(purelib
) directory of the current environment which points to the absolute path of the current project..dist-info
directory with theINSTALLER
,METADATA
,RECORD
andentry_points.txt
files.I took this opportunity to improve the installed packages detection by improving the detection of the
purelib
directory which was not so trivial after all.