-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable parallelization in CI #2663
Conversation
Might want to strip the values before comparision. |
Thanks! I'll commit it soon. I wonder how I broke that test with my change tho. The parallel feature prints more new lines? |
I think it's OK now - Cirrus CI seems to fail randomly (before even starting to test). I don't think it's related.. |
Output testing across python versions and platforms can get wierd. The wierd bit is that the new line occured only for one env. I have retriggered the failing Cirrus CI job. |
@abn the cirrus bug seems to be known and was declared as fixed, I sent the failing task in the relevant issue. Hopefully they'll reopen it. |
Looks good now, any comments? |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
As discussed in #2648 this check is probably no longer needed.