Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable parallelization in CI #2663

Merged
merged 5 commits into from
Jul 28, 2020
Merged

Conversation

aviramha
Copy link
Contributor

As discussed in #2648 this check is probably no longer needed.

@aviramha aviramha mentioned this pull request Jul 13, 2020
@abn
Copy link
Member

abn commented Jul 14, 2020

>       assert expected == tester.io.fetch_output()
E       AssertionError: assert '\nUpdating de...1.2 9cf87a2)\n' == '\nUpdating dep... tag found.\n\n'
E           

Might want to strip the values before comparision.

@aviramha
Copy link
Contributor Author

Thanks! I'll commit it soon. I wonder how I broke that test with my change tho. The parallel feature prints more new lines?

@aviramha
Copy link
Contributor Author

I think it's OK now - Cirrus CI seems to fail randomly (before even starting to test). I don't think it's related..

@abn
Copy link
Member

abn commented Jul 15, 2020

Thanks! I'll commit it soon. I wonder how I broke that test with my change tho. The parallel feature prints more new lines?

Output testing across python versions and platforms can get wierd. The wierd bit is that the new line occured only for one env.

I have retriggered the failing Cirrus CI job.

@aviramha
Copy link
Contributor Author

@abn the cirrus bug seems to be known and was declared as fixed, I sent the failing task in the relevant issue. Hopefully they'll reopen it.
cirruslabs/cirrus-ci-docs#592

@aviramha
Copy link
Contributor Author

Looks good now, any comments?

@abn abn changed the base branch from develop to master July 28, 2020 12:05
@abn abn merged commit c77299e into python-poetry:master Jul 28, 2020
@aviramha aviramha deleted the parallel_in_ci branch July 28, 2020 16:21
Copy link

github-actions bot commented Mar 1, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants