Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix non-posix paths with file:// protocol on Windows #2750

Merged
merged 5 commits into from
Jul 30, 2020
Merged

Fix non-posix paths with file:// protocol on Windows #2750

merged 5 commits into from
Jul 30, 2020

Conversation

fredrikaverpil
Copy link
Contributor

Pull Request Check List

Resolves: #2744

  • Added tests for changed code.
  • Updated documentation for changed code.

@fredrikaverpil
Copy link
Contributor Author

@abn hm, the errors I am getting... I don't think they are related to my PR, right?

@fredrikaverpil fredrikaverpil changed the title Fix win link backslashes Fix non-posix paths with file:// protocol on Windows Jul 30, 2020
abn
abn requested changes Jul 30, 2020
View reviewed changes
Copy link
Member

@abn abn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

str use is redundant, also we could possible simply use Path.as_url(). Additionally, the existing test case can be improved to cover this case.

poetry/installation/chef.py Outdated Show resolved Hide resolved
tests/installation/test_chef.py Outdated Show resolved Hide resolved
@abn
Copy link
Member

abn commented Jul 30, 2020 •
edited
Loading

I don't think they are related to my PR, right?

Correct. #2751

fredrikaverpil and others added 2 commits July 30, 2020 14:46
@fredrikaverpil @abn
Use Path.as_uri
c9229dd 
Co-authored-by: Arun Babu Neelicattu <arun.neelicattu@gmail.com>
Update test
8739303
@abn abn merged commit 6473994 into python-poetry:master Jul 30, 2020
@abn abn mentioned this pull request Sep 23, 2020
Closed
3 tasks
@abn abn linked an issue Sep 23, 2020 that may be closed by this pull request
Poetry 1.1.0b2 fails to install zipp when trying to install poetry-core #2911
Closed
3 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 1, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@abn abn abn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@fredrikaverpil @abn