Support build system requirements #2794
Conversation
Prior to this change, when checking solver results the tests cases relied on the weaker equality check of the `Package` class. With python-poetry/poetry-core#53, the check has been made stricter. This change, while having no functional impact, ensures that once poetry-core is updated, tests do not fail unexpectedly.
abn
force-pushed
the
fix-build-requires
branch
from
5aa61a5
to
b615543
Compare
|
Any updates here @abn ? Is this still being developed? |
|
Any updates on this? |
|
@mdgoldberg @schneiderfelipe I am guessing there is still interest in this? I have had some push backs from core about this. But happy to push it forward. |
Very much interested. Out of curiosity, what's holding this back? |
|
@abn, |
|
@abn are you still on this? Would be very helpful 🙂 |
|
@GuillaumeDesforges guess now I am :D unfortunately python-poetry/poetry-core#58 got a bit stuck. Let me have a rethink with the new groups changes. The appraoch I took there will no longer really work. Since "dev" is not necesarily a group that is always going to be present. That said, in the interim I would recommend you redefine the dependency like so. poetry add --group build 'cpython@*'Or use the TOML. [tool.poetry.group.build.dependencies]
cpython = "*"Personally, I do not like that I'd have to re-specify the dependency, but that is where it is at present. |
|
Closing this in favour of #5401 for now as the core issue was stuck without concensus. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This change adds support of build requirements. This is implemented such that build requirements are always installed on
poetry installandpoetry install --no-devsince the package installation will requirebuild-system.requirespackages. Whenpoetry buildis executed, existing behaviour is retained for cases where additional build requirements are not required. If additional, dependencies are required (eg:cython) these and only these are installed before build and environment executable is configured for use when build script is executed.Resolves: #2789
Requires: #2732 python-poetry/poetry-core#58