-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: adding a note about being able to specify a package's source repository #3477
Docs: adding a note about being able to specify a package's source repository #3477
Conversation
I link https://github.com/python-poetry/poetry/issues/3269 as somewhat related. |
@sinoroc, thanks for the link. I also updated the list of options in the documentation for the |
Sorry in advance, if this isn't the right place to ask... also, if there's documentation on what I'm about to say, please LMK! I wasn't able to find anything on It is clear to me, from the documentation in this MR, that one purpose of Before elaborating what is not clear to me, please consider the
It is not clear to me if:
Lastly, I looked for an example |
There's another PR doing this, #3400. It's just missing the CLI docs. |
6b2485d
to
3e884b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rebased onto current master. Just waiting on the CI to be unbroken to merge this (see #4753).
…pository (python-poetry#3477) * Adding a note about being able to specify a package's source repository * Updating the list of options for the add command
…pository (python-poetry#3477) * Adding a note about being able to specify a package's source repository * Updating the list of options for the add command
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Pull Request Check List
Resolves: #3476
Adding a little note to the documentation about the ability to specify the source repository for a dependency.
As mentioned in the linked issue, poetry's dependency resolution was failing because the first private repository poetry looked in for a specified dependency returned a 404. Whether or not that's the right behavior is a different discussion, but the problem can immediately be solved using the
source
property.