Added pip style keyring password lookup as a fallback. #4086
Conversation
This way Poetry gives keyring backends like Microsoft's `artifacts-keyring` or Google's `keyrings.google-artifactregistry-auth` a change to retrieve the credentials. Since Microsoft Azure DevOps Personal Access Tokens will expire after some time the `artifacts-keyring` implementation will generate a new one for you to counteract that.
Darsstar
force-pushed
the
pip-style-keyring-fallback
branch
from
e47c737
to
6d28c56
Compare
|
I tested this branch against Google Artifact Registry and can confirm that it works as expected. Thanks for contributing this! |
|
I can also confirm this PR works for Google Cloud. I notice that |
|
The latest changes have resolved publishing ( |
…wordManager so that Publisher can use Authenticator instead of PasswordManager.
- Authenticator and its tests got moved into utils.
- No longer retrieve "repositories.{name}.url" in two steps ("repositories.{name}", then "url") since that does not allow us to use environment variable POETRY_REPOSITORIES_{name}_URL.
|
SonarCloud Quality Gate failed.
|
|
Could this be bumped and looked into? |
|
Nice job! I was just going to start implementation of this on my own, as I'm facing the issue with GCP's Artifact Registry keyring. |
|
Do we have any release date for this fix? We need it to properly work with GCP Artifact Registry too. |
|
Hello! Any chance we can escalate this? We need this in ASAP. Cheers! |
|
From our side there is also keen interest in using this! |
|
Poetry Maintainers/Owners (@abn @sdispater @finswimmer @stephsamson ) -- anything I can be doing to help this issue along? |
|
I am also quite interested in this feature. Any updates on the release date? |
|
I am also waiting with projects to migrate them from classic pip to poetry because we can't get packages from Azure Feeds with PAT using poetry. This PR will give us that chance. |
|
I am waiting for it too to use poetry with gcp artifactory regitry PyPi repo |
|
Sorry, the readme in the changed files do not provide sufficient guidance. I don't know how to follow 'It will need to be properly installed into Poetry's virtualenv, preferrably by installing a plugin.', since I don't understand which plugin we are talking about. Do you think you could help with an improved readme? |
|
@lynochka to be honest I don't know what does this sentence in curl -sSL https://raw.githubusercontent.com/python-poetry/poetry/master/install-poetry.py | python - --preview |
|
I'm still having this issue with 1.2.0a2. I even embed the credentials in the URL and it ignores them. |
|
Is it possible to add this feature in version |
…-fallback Added pip style keyring password lookup as a fallback.
…-fallback Added pip style keyring password lookup as a fallback.
…-fallback Added pip style keyring password lookup as a fallback.
…-fallback Added pip style keyring password lookup as a fallback.
…-fallback Added pip style keyring password lookup as a fallback.
…-fallback Added pip style keyring password lookup as a fallback.
|
For people that cannot wait for this feature, here's some steps to use Google Artifact Registry with the keyring functionality: GoogleCloudPlatform/artifact-registry-python-tools#17 (comment) Hope this helps! |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This way Poetry gives keyring backends like Microsoft's
artifacts-keyringor Google'skeyrings.google-artifactregistry-autha chance to retrieve the credentials. Since Microsoft's Azure DevOps Personal Access Tokens will expire after some time theartifacts-keyringimplementation will generate a new one for you to counteract that.By "pip style" I mean keyring requests based on the repository url instead of poetry config paths.
Tested by modifing installation/authenticator.py on my Poetry 1.2.0a1 installation.
Pull Request Check List
Resolves: #3344